-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
edit doesn't work #76
Comments
It does work for me on every copied native and manually created rules! |
Well, good for you? It never works for me... Currently playing classic season of Discovery. 100% reproducible |
Well, VERY interesting! But, and i quote from this issue #74:
I'm sure as a Dev you know how to correctly report a bug, so ... WHY YOU DO NOT DO SO?! The Majority is playing Retail and it is more then very likely to suppose you have the bug in Retail if there is no other information given except "it's not working" or "nothing happens"... You don't think so? 🤷♂️ |
The following LUA Error pops on Classic Ära when "Copy", "Edit" or "View" Native or Manually Created Rules! Message: ...Ons/Vendor/systems/itemproperties/itemproperties.lua:184: attempt to call method 'IsItemAccountBoundInTooltip' (a nil value)
Time: Sat Jul 20 03:23:34 2024
Count: 2
Stack: ...Ons/Vendor/systems/itemproperties/itemproperties.lua:184: attempt to call method 'IsItemAccountBoundInTooltip' (a nil value)
[string "@Interface/AddOns/Vendor/systems/itemproperties/itemproperties.lua"]:184: in function <...Ons/Vendor/systems/itemproperties/itemproperties.lua:72>
[string "=(tail call)"]: ?
[string "@Interface/AddOns/Vendor/rules/evaluate.lua"]:12: in function <Interface/AddOns/Vendor/rules/evaluate.lua:7>
[string "@Interface/AddOns/Vendor/rules/evaluate.lua"]:71: in function <Interface/AddOns/Vendor/rules/evaluate.lua:67>
[string "=(tail call)"]: ?
[string "@Interface/AddOns/Vendor/features/ui_dialogs/EditRule.lua"]:332: in function `ValidateScript'
[string "@Interface/AddOns/Vendor/features/ui_dialogs/EditRule.lua"]:513: in function `Setup'
[string "@Interface/AddOns/Vendor/features/ui_dialogs/EditRule.lua"]:479: in function <...rface/AddOns/Vendor/features/ui_dialogs/EditRule.lua:472>
[string "@Interface/AddOns/Vendor/_ui/UI.lua"]:312: in function `SetRule'
[string "@Interface/AddOns/Vendor/features/ui_dialogs/dialogs.lua"]:45: in function `ShowEditRule'
[string "@Interface/AddOns/Vendor/features/ui_vendor/RuleItem.lua"]:185: in function `Edit'
[string "@Interface/AddOns/Vendor/features/ui_vendor/RuleItem.lua"]:238: in function `?'
[string "@Interface/AddOns/Vendor/_ui/contextmenu.lua"]:82: in function `OnItemClicked'
[string "@Interface/AddOns/Vendor/_ui/contextmenu.lua"]:31: in function <Interface/AddOns/Vendor/_ui/contextmenu.lua:30>
Locals: itemObj = <table> {
GetItemLocation = <function> defined @Interface/AddOns/Blizzard_ObjectAPI/Classic/Item.lua:66
SetItemLink = <function> defined @Interface/AddOns/Blizzard_ObjectAPI/Classic/Item.lua:56
HasItemLocation = <function> defined @Interface/AddOns/Blizzard_ObjectAPI/Classic/Item.lua:70
LockItem = <function> defined @Interface/AddOns/Blizzard_ObjectAPI/Classic/Item.lua:113
itemLocation = <table> {
}
GetItemID = <function> defined @Interface/AddOns/Blizzard_ObjectAPI/Classic/Item.lua:98
IsItemDataCached = <function> defined @Interface/AddOns/Blizzard_ObjectAPI/Classic/Item.lua:216
GetInventoryTypeName = <function> defined @Interface/AddOns/Blizzard_ObjectAPI/Classic/Item.lua:210
GetCurrentItemLevel = <function> defined @Interface/AddOns/Blizzard_ObjectAPI/Classic/Item.lua:172
GetItemQualityColor = <function> defined @Interface/AddOns/Blizzard_ObjectAPI/Classic/Item.lua:183
UnlockItem = <function> defined @Interface/AddOns/Blizzard_ObjectAPI/Classic/Item.lua:119
Clear = <function> defined @Interface/AddOns/Blizzard_ObjectAPI/Classic/Item.lua:74
GetItemIcon = <function> defined @Interface/AddOns/Blizzard_ObjectAPI/Classic/Item.lua:125
IsItemLocked = <function> defined @Interface/AddOns/Blizzard_ObjectAPI/Classic/Item.lua:109
GetItemLink = <function> defined @Interface/AddOns/Blizzard_ObjectAPI/Classic/Item.lua:146
SetItemLocation = <function> defined @Interface/AddOns/Blizzard_ObjectAPI/Classic/Item.lua:51
GetItemName = <function> defined @Interface/AddOns/Blizzard_ObjectAPI/Classic/Item.lua:135
IsItemInPlayersControl = <function> defined @Interface/AddOns/Blizzard_ObjectAPI/Classic/Item.lua:92
GetItemQuality = <function> defined @Interface/AddOns/Blizzard_ObjectAPI/Classic/Item.lua:161
GetItemGUID = <function> defined @Interface/AddOns/Blizzard_ObjectAPI/Classic/Item.lua:199
GetInventoryType = <function> defined @Interface/AddOns/Blizzard_ObjectAPI/Classic/Item.lua:188
IsItemEmpty = <function> defined @Interface/AddOns/Blizzard_ObjectAPI/Classic/Item.lua:80
GetStaticBackingItem = <function> defined @Interface/AddOns/Blizzard_ObjectAPI/Classic/Item.lua:88
SetItemID = <function> defined @Interface/AddOns/Blizzard_ObjectAPI/Classic/Item.lua:61
IsDataEvictable = <function> defined @Interface/AddOns/Blizzard_ObjectAPI/Classic/Item.lua:227
ContinueWithCan I've not tested any further as of im not interested in Classic but... it seems this AddOn is not working for Classic Ära properly overall, there are many functions missing and also many LUA Errors that pops! |
I would have given you the Lua error because I don't actually know how to get the Lua error... Also it doesn't naturally occur to me that this is the same code base for all variations of wow. In fact it isn't even really clear To me what retail is because that's not a term that you actually see in battlenet. I've got a cat on my lap at this exact second but I can tell you that as of today all of The client and add-ons are up to date. I can look up exact versions later. |
fair, but also doesn't seem to be 100% accurate all time. From what I can tell this warning simply happens any time they bump any version (could be wrong). Which is an awful way to do that. Intelligently it should only happen on a semantic version change (they probably don't do semver). I don't know whether they use semantic versions or not though. You also get warnings when plugins throw a ton of lua errors because it might cause performance issues. I get those errors too. vendor is v6.6.0
I think, but am not certain, that curseforge allows you to not list addons for classic/cataclysm if they aren't intended to work. |
If I click view on a native rule that opens, if I click copy, that opens, if I click edit on a custom rule, nothing happens.
The text was updated successfully, but these errors were encountered: