From a960883869be3a8b773d84703058805c9c159821 Mon Sep 17 00:00:00 2001 From: Andrew Petro Date: Wed, 21 Mar 2018 07:40:55 -0500 Subject: [PATCH 1/2] fix: fail safe when portlet lacks title In case where portlet.title undefined don't consider that portlet a filter match on title but don't exception out the whole filtering attempt --- web/src/main/webapp/my-app/marketplace/services.js | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/web/src/main/webapp/my-app/marketplace/services.js b/web/src/main/webapp/my-app/marketplace/services.js index ba82ad061..4cd96915a 100644 --- a/web/src/main/webapp/my-app/marketplace/services.js +++ b/web/src/main/webapp/my-app/marketplace/services.js @@ -257,7 +257,9 @@ define(['angular', 'jquery'], function(angular, $) { var lowerSearchTerm = searchTerm.toLowerCase(); // check title - if (portlet.title.toLowerCase().indexOf(lowerSearchTerm) !== -1) { + if (portlet + && portlet.title + && portlet.title.toLowerCase().indexOf(lowerSearchTerm) !== -1) { return true; } From 705b37a609ed384ef5553381b32eca9e7b0c3cbd Mon Sep 17 00:00:00 2001 From: Andrew Petro Date: Wed, 21 Mar 2018 07:54:22 -0500 Subject: [PATCH 2/2] docs(changelog): Note adding fail-safe when `portlet.title` undefined --- CHANGELOG.md | 1 + 1 file changed, 1 insertion(+) diff --git a/CHANGELOG.md b/CHANGELOG.md index eb0ff78fd..bad4feeca 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -22,6 +22,7 @@ and this project adheres to [Semantic Versioning](http://semver.org/spec/v2.0.0. * Removed defective (always zero) search results total badge (#797) * Alphabetically sort by `title` not `name` in app directory browse (#791) * Made `relatedPortlets` arrays empty in `entries.json` (#787) +* Fail safe when `portlet` data record lacks `title` (#798) ### Dependency upgrades