Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Patch parsing error messages #8

Open
abhinav opened this issue Apr 21, 2021 · 0 comments
Open

Patch parsing error messages #8

abhinav opened this issue Apr 21, 2021 · 0 comments
Labels
bug Something isn't working

Comments

@abhinav
Copy link
Contributor

abhinav commented Apr 21, 2021

The machinery for parsing patches is currently convoluted, with multiple temporary files created inside token.FileSets so that when failures do occur, we have no obvious correlation to positions in the patch.

We should simplify that by not introducing these temporary file sets, or mapping positions back to the original patch file. Go syntax error messages should specify exact positions in the patch files.
@abhinav abhinav added the bug Something isn't working label Apr 21, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working
Milestone
No milestone
Development

No branches or pull requests
1 participant
@abhinav