Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[UX/UI] All numbers >4 digits need commas #222

Open
wrenaria opened this issue Oct 31, 2024 · 1 comment
Open

[UX/UI] All numbers >4 digits need commas #222

wrenaria opened this issue Oct 31, 2024 · 1 comment
Assignees
@UcDust
Labels
UX / UI

Comments

@wrenaria
Copy link

Describe the bug
All numbers that are greater than 4 digits in length should have commas to improve readability. Currently no commas are used.

Example of desired format
1
10
100
1000
10,000
100,000
1,000,000

Example of current format

Screenshot 2024-10-31 at 4 15 48 PM

Screenshot 2024-10-31 at 4 15 40 PM

Screenshot 2024-10-31 at 4 21 26 PM
UcDust added a commit that referenced this issue Nov 1, 2024
@UcDust
update number formats for result counts to have commas #222
7e2b1c7
jrmerz pushed a commit that referenced this issue Nov 5, 2024
@UcDust
[BUG/FEAT] updates and fixes after more testing on dev (#224)
6b3327f 
* hide typeahead search in filters on first load since ui is collapsed, remove debug code

* add material/format to item page

* fix for imagelist items that have only 1 page, to not show the multi page icon on search tiles #217

* bookreader style updates #218

* update highlighted collection card to show image override #221

* update number formats for result counts to have commas #222

* add delete to admin ui cards, also fix glitch when deleting certain collections #220

* pagination/scrollTo fixes for search page and other parts of app #226 #157

* update link to collections on search to only return if > 1 results when a collection is selected/part of url #219

* fix for image size rendering on item/ark:/87293/d3cv4bw94
@UcDust
Copy link
Contributor

UcDust commented Nov 5, 2024

@wrenaria I think this should be deployed on dev now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@UcDust UcDust

Labels
UX / UI
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@wrenaria @UcDust