Unnecessary queries to the deduping service

[bbusenius]

Expected behavior

Queries to the deduping service should only be made if either there is an issns parameter or an sfx parameter.

The following are examples of good queries:

/cgi-bin/holdings?code=48976&function=holdings&callback=vufind&sfx=1000000000237586

/cgi-bin/holdings?code=48976&function=holdings&callback=vufind&issns=1762-6110

Actual behavior

Unnecessary queries are being made to the deduping service. The unnecessary queries look like this:

/cgi-bin/holdings?code=48976&function=holdings&callback=vufind 

These queries do not have issns or sfx parameters. If neither one of these is present, a query to the sfx service should not be made.

Related Files

• module/UChicago/src/UChicago/AjaxHandler/GetDedupedEholdings.php
• themes/phoenix/js/phoenix.js
• module/UChicago/config/module.config.php
• local/config/vufind/config_base.ini

[fseatonuc]

I was doing some log analysis on the SFX server because of an outage we had yesterday (11/7) and I noticed that these null queries appeared to have started on 10/7. I didn't' look at the modification times on the code base, but does that make sense?

[bbusenius]

It doesn't make sense to me. It looks like we added sfx numbers to the deduping service in January. That's when I would have expected it to start. I would have expected it to have been happening all along.

[fseatonuc]

Maybe Keith made a change in October that caused the behavior to change? I'll look at the logs some more.

[fseatonuc]

FYI - Keith confirmed today that the reason the null queries to the deducing service were passed through to the SFX server was from debugging code that got activated on 10/7. He removed that code last week. Still, this bug (#85) should still be fixed.