Add an option to disable the UmbracoFile sink when using another sink #12720
Nikkelmann
started this conversation in
Features and ideas
Replies: 0 comments
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
-
Currently when setting up serilog with another sink in the json configuration, Umbraco still adds the UmbracoFile "sink".
I would have expected that it would only add this sink, if no other sink was found.
Loggin to the json files on disk also causes a problem when publishing via Web Deploy, since the files are locked and cannot be deleted (which in it self is also an issue, since we kinda want to keep the log).
In my case I've setup the log with elastic search as such:
Looking through the source code it seems like the only option is to add a flag, that tells the AddLogger to not setup the UmbracoFile sink:
Umbraco-CMS/src/Umbraco.Web.Common/Extensions/ServiceCollectionExtensions.cs
Line 80 in 9326cc5
Beta Was this translation helpful? Give feedback.
All reactions