The Log Viewer date picker icon doesn't change in Dark Mode

[readingdancer]

Which Umbraco version are you using? (Please write the exact version, example: 10.1.0)

15.3.0.rc

Bug summary

When running Umbraco in Dark Mode, the Log Viewer icons are still black and become almost invisible.

Specifics

This is within the back office when looking at the Log Viewer:

Steps to reproduce

Open up Umbraco 15+ and navigate to the Settings / Log Viewer.

Change the UI to use Dark Mode... see the above result.

Expected result / actual result

What I would expect is the icons change to white to be visible... I have a PR coming :)

[github-actions]

Hi there @readingdancer!

Firstly, a big thank you for raising this issue. Every piece of feedback we receive helps us to make Umbraco better.

We really appreciate your patience while we wait for our team to have a look at this but we wanted to let you know that we see this and share with you the plan for what comes next.

• We'll assess whether this issue relates to something that has already been fixed in a later version of the release that it has been raised for.
• If it's a bug, is it related to a release that we are actively supporting or is it related to a release that's in the end-of-life or security-only phase?
• We'll replicate the issue to ensure that the problem is as described.
• We'll decide whether the behavior is an issue or if the behavior is intended.

We wish we could work with everyone directly and assess your issue immediately but we're in the fortunate position of having lots of contributions to work with and only a few humans who are able to do it. We are making progress though and in the meantime, we will keep you in the loop and let you know when we have any questions.

Thanks, from your friendly Umbraco GitHub bot 🤖 🙂

[nielslyngsoe]

Hi @readingdancer thanks for reporting.

I see that this UI is using its own implementation of a date input. I would recommend changing this to use the uui-input component set to type date

See more here: https://uui.umbraco.com/?path=/story/uui-input--date-time-local

These changes goes into the umb-log-viewer-date-range-selector element.

I hope this gives enough guide for who ever likes to make a PR for this

Thanks in advance

[github-actions]

Hi @readingdancer,

We're writing to let you know that we would love some help with this issue. We feel that this issue is ideal to flag for a community member to work on it. Once flagged here, folk looking for issues to work on will know to look at yours. Of course, please feel free work on this yourself ;-). If there are any changes to this status, we'll be sure to let you know.

For more information about issues and states, have a look at this blog post.

Thanks muchly, from your friendly Umbraco GitHub bot :-)

[iOvergaard]

@nielslyngsoe, even though it doesn't use the right component, the endresult is still a uui-input with type="date". That means we are using the native browser date picker, which apparently does not support dark mode. I'm wondering how do you actually tell the browser to show its native things in dark mode. Do you have to target a ::webkit specific selector as was done in the proposed PR?

input[type='date']::-webkit-calendar-picker-indicator {
  filter: inverse(1);
}

If you set Storybook to dark mode, it does not change the input fields, so I guess that could be a solution: Do not change the background-color on inputs:

[nielslyngsoe]

@iOvergaard you are right, sorry my mistake.

I investigated a bit more and there is a color-scheme: dark; that can be set on inputs.

I will write a suggestion on the PR.