Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: entry config should be defined as IndexMap #1765

Closed
wants to merge 1 commit into from

Conversation

xusd320
Copy link
Contributor

@xusd320 xusd320 commented Jan 23, 2025

Ref #1763

  • It's really useful if your PR references an issue where it is discussed ahead of time. In many cases, features are absent for a reason. For large changes, please create an RFC.
  • This message body should clearly illustrate what problems it solves.
  • Ideally, include a test that fails without this PR but passes with it.

Tests

  • Run the tests and other checks with just ready

Edits

  • Please ensure that 'Allow edits from maintainers' is checked. PRs without this option may be closed.

@xusd320 xusd320 requested a review from Jinbao1001 January 23, 2025 06:06
Copy link

codecov bot commented Jan 23, 2025

Codecov Report

Attention: Patch coverage is 66.66667% with 1 line in your changes missing coverage. Please review.

Project coverage is 54.99%. Comparing base (3524214) to head (f0ae422).
Report is 1 commits behind head on master.

Files with missing lines Patch % Lines
crates/mako/src/module_graph.rs 50.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1765      +/-   ##
==========================================
- Coverage   55.04%   54.99%   -0.05%     
==========================================
  Files         180      180              
  Lines       18146    18168      +22     
==========================================
+ Hits         9988     9992       +4     
- Misses       8158     8176      +18     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@xusd320 xusd320 closed this Jan 23, 2025
@xusd320 xusd320 reopened this Jan 23, 2025
@xusd320 xusd320 closed this Jan 23, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants