Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support of duplicates prevention #566

Open
umputun opened this issue Jan 18, 2020 · 4 comments
Open

Add support of duplicates prevention #566

umputun opened this issue Jan 18, 2020 · 4 comments

Comments

@umputun
Copy link
Owner

umputun commented Jan 18, 2020

The idea is to add an api and both backend and frontend support notifying the user if a similar comment already posted to the thread. This thing should be optional.

Probably on the backend side, we may have a new method similar to createCommentCtrl but checking for possible dups.

@umputun umputun changed the title Add support of duplication prevention Add support of duplicates prevention Jan 18, 2020
@paskal
Copy link
Collaborator

paskal commented Jan 18, 2020

In my opinion, it's too specific for a particular use-case and I am against increasing the complexity of the whole system for everyone because of a single customer, even the biggest one.

Reddit solves such tasks by the community, I think we are not that special and can rely on the voting system as well.

@umputun
Copy link
Owner Author

umputun commented Jan 18, 2020

well, github is trying smth similar as well. Generally, it is not an easy task and I don't think this is a high priority, but I do see a value in this. Regardless of the use cases in a long discussion, people tend to post the same links and if we can notify them (not reject, just notify and allow ok/cancel) it could be helpful

@paskal
Copy link
Collaborator

paskal commented Jan 18, 2020

I see the complexity and predictable amount of errors around trying to understand if the links are the same, but it might indeed be useful.

@sleshJdev
Copy link

sleshJdev commented Jul 23, 2020

Seems that boltdb doesn't provide any built-in support for any more or less strong ad-hoc text processing. My vision is that we need some additional storage which has this functionality to replicate data from boltdb into that storage and run ad-hoc text analysis there. It also could be used for full-text search in the future #734

Another less popular option is to implement it in go: pull the related comment from boltdb into memory and perform text processing. It could work if the amount of data is not big, but in general, it is not reliable at all. To speed it a bit up we could pre-process comments and keep k-grams in boltdb and use them later. But it seems like inventing the wheel.

@umputun, what do you think?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants