Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PNPM_VERSION env var is not respected anymore if the version is specified in the package.json #43

Open
adamsosterics opened this issue Apr 12, 2023 · 0 comments
Labels
bug Something isn't working

Comments

@adamsosterics
Copy link

Describe the bug
The documentation says that we can set the PNPM_VERSION env var to control which pnpm version is installed during the heroku build.
However, when we set the engines.pnpm in the package.json, the buildpack is using that value over the env var which is not what I'd expect reading the documentation.
For us, this is not a big deal, it was just surprising. I'm also not sure this was an intentional change or just a coincidence. Probably it's worth documenting and/or fixing.
I think this commit introduced this new behaviour.

To Reproduce
Steps to reproduce the behavior:

  1. Set the pnpm version in the package.json like this:
"engines": {
    "node": "16.x",
    "pnpm": "8.x"
  }
  1. Set the PNPM_VERSION env var in your Heroku app to 7.30.5
  2. Build your app
  3. See that the buildpack is installing pnpm 8.2.0

Versions (please complete the following information):

  • Heroku Stack: heroku-22
  • Node Version: 16.20.0
  • NPM or Yarn Version: NPM 8.19.4
  • Buildpack Version: latest

Additional context
Add any other context about the problem here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant