Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make Pharsie Language (code prs) a gateway language #181

Closed
theNerd247 opened this issue Jul 12, 2023 · 3 comments · Fixed by #182
Closed

Make Pharsie Language (code prs) a gateway language #181

theNerd247 opened this issue Jul 12, 2023 · 3 comments · Fixed by #182
Assignees
Labels
bug Something isn't working Priorty/High High priority issue

Comments

@theNerd247
Copy link
Contributor

theNerd247 commented Jul 12, 2023

The following issue was presented on Zulip:

We do not have all the languages embedded in gatewayAdmin. Say for e.g. Dari language which is one of the Parsi Arabic languages has the code prs and prs-AF which does not show in the gatewayAdmin language dropdown list. How do we address this issues. We are hitting a wall with this and very soon many more will follow. We need to address this sooner than later. Please help as the Parsi team needs to publish their work and this has become a major blocker.

It was discovered by @mandolyte that the prs language code in languages.json has "gw": false value which is hiding it from display in gateway edit.

There are 2 shallow issues here:

  1. change prs to be a gateway language (set "gw": true).
  2. add the prs-AF as a new entry. (Though I'm not sure what the fields should be)

There is a deeper issue: gateway-admin is still pulling language codes from a static file. I'm not sure if this is on purpose. Which brings up a few questions.

@theNerd247
Copy link
Contributor Author

See #189 for the quick fix release
@elsylambert is this issue still open or should we close it since other related issues are still open?

@elsylambert
Copy link

elsylambert commented Aug 21, 2023

@theNerd247 Closing this issue. We have #185 written up after a final fix is done to the language list display in gatewayAdmin by #184

@theNerd247
Copy link
Contributor Author

Thank you! 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working Priorty/High High priority issue
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants