Removing patch to force popups into new tabs

[Eloston]

Followup of #38 (comment)

Popup blocking is a common practice these days, and many websites have moved to HTML/CSS-based popups. Is it still necessary to force all popups into tabs? What do you guys think?

(I'm okay to remove this feature or move it behind a flag.)

[achesnok]

@Eloston I would like to have a toggle flag for this feature. Even in the simplest browser-wide implementation.

[kramred]

I'm voting for keeping the feature, and introducing a flag in case people want to toggle the behaviour

[Ahrotahn]

My initial reaction would be to say to keep the feature, but this post got me thinking about how often I've encountered popups and I wonder if I would notice if it were removed. I guess I wouldn't be able to really know until I could turn it off for a while.

After messing with it during the update I know what would need to be done to add the flag and don't mind doing the work if that's the route you want to take.

[Eloston]

That'd be great! Our users will certainly appreciate it 👍

[wchen342]

There is one particular scenario that I encountered in the past (in Firefox, not in Chromium but I assume something similar can happen). So some websites has a mailto: link and if you click on it, it will open the default mail client. However, if you set the default mail client to your browser, then the browser will go into a loop of keeping opening the same mailto: link in new tabs infinitely until there are hundreads of blank tabs. I am not sure whether opening in a new window will solve the problem though.