Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Erroneous converter for unit PH #133

Open
chile12 opened this issue Feb 8, 2019 · 3 comments
Open

Erroneous converter for unit PH #133

chile12 opened this issue Feb 8, 2019 · 3 comments
Labels
analysis

Comments

@chile12
Copy link

chile12 commented Feb 8, 2019

Hi, I found an erroneous definition of the PH unit here:
https://github.com/unitsofmeasurement/uom-systems/blob/master/ucum-java8/src/main/java/systems/uom/ucum/UCUM.java#L753

Multiplying the whole logarithm by -1 means basically to divide its result by -1.
The subsequent converter produces a whole lotta NaNs.
@keilw keilw added the analysis label Feb 8, 2019
@keilw
Copy link
Member

keilw commented Feb 8, 2019 •
edited
Loading

Could you point to a better definition?

It is approximately the negative of the base 10 logarithm of the molar concentration, measured in units of moles per liter,...

(https://en.wikipedia.org/wiki/PH) sounds like it, so is there

  • an alternate formula
  • Unit tests to show what you mentioned above?

@keilw
Copy link
Member

keilw commented Oct 4, 2020

Any progress or update on this?

@chile12
Copy link
Author

chile12 commented Oct 5, 2020 via email

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
analysis
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@keilw @chile12