You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Brief:
Code uses NaNs and calls std::isnan(), which is erroneous with -ffast-math.
Detail:
The launch parameter init_NEDy defaults to a vector of NaNs (quiet_NaN in std) if left unspecified by the user. This is later checked in std::isnan() to see if user has specified a full and correct list of 4 elements. However, this check will always return false due to -ffast-math (used in CMakeLists.txt) which further enables -fno-signaling-nans and -ffinite-math-only.
Temporary Fix:
Always provide this launch param. To specify an "invalid param", launch with a list of one element. @ajshankVerified - this works.
Suggested fix:
Don't use -ffast-math? Use some other compliant operation?
The text was updated successfully, but these errors were encountered:
Affects:
ros2-devel
branch.Node:
waypoint_manager
Brief:
Code uses NaNs and calls
std::isnan()
, which is erroneous with-ffast-math
.Detail:
The launch parameter
init_NEDy
defaults to a vector of NaNs (quiet_NaN
instd
) if left unspecified by the user. This is later checked instd::isnan()
to see if user has specified a full and correct list of 4 elements. However, this check will always returnfalse
due to-ffast-math
(used in CMakeLists.txt) which further enables-fno-signaling-nans
and-ffinite-math-only
.Temporary Fix:
Always provide this launch param. To specify an "invalid param", launch with a list of one element.
@ajshank Verified - this works.
Suggested fix:
Don't use
-ffast-math
? Use some other compliant operation?The text was updated successfully, but these errors were encountered: