Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug]: Safari iOS Dialog BodyScrollLock not working #1423

Closed
94726 opened this issue Nov 14, 2024 · 1 comment · Fixed by #1428
Closed

[Bug]: Safari iOS Dialog BodyScrollLock not working #1423

94726 opened this issue Nov 14, 2024 · 1 comment · Fixed by #1428
Assignees
Labels
bug Something isn't working

Comments

@94726
Copy link
Contributor

94726 commented Nov 14, 2024

Environment

Developement/Production OS: Windows 10 19043.1110
Node version: 20.15.0
Package manager: [email protected]
Radix Vue version: 1.9.9
Vue version: 3.5.12
Nuxt version: 3.14.159
Nuxt mode: universal
Nuxt target: server
CSS framework: [email protected]
Client OS: MacOS Version 14.6.1
Browser: Chrome 130.0.6723.117

Link to minimal reproduction

https://www.radix-vue.com/components/dialog.html#nested-dialog

Steps to reproduce

On iOS Safari:

  1. scroll down, such that the native safari footer collapses
  2. open dialog
  3. scroll outside the dialog

Describe the bug

This bug allows one to still scroll the body, when a Dialog is opened, on mobile safari.

Expected behavior

Should be able to scroll the body.

Context & Screenshots (if applicable)

This bug only works when the native safari footer is collapsed (e.g. when previously scrolled down)
Otherwise it behaves as expected 🤷
image
Then it'll allow you to continue to scroll, with the dialog being open.

RadixScrollLockIssue.mov
@94726 94726 added the bug Something isn't working label Nov 14, 2024
94726 added a commit to 94726/radix-vue that referenced this issue Nov 14, 2024
@zernonia
Copy link
Member

related to #575

@zernonia zernonia self-assigned this Nov 16, 2024
@zernonia zernonia linked a pull request Nov 16, 2024 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
2 participants