Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat: framework based icon types #395

Closed
3 tasks done
eye-wave opened this issue Jan 13, 2025 · 1 comment
Closed
3 tasks done

Feat: framework based icon types #395

eye-wave opened this issue Jan 13, 2025 · 1 comment
Labels
enhancement New feature or request

Comments

@eye-wave
Copy link

Clear and concise description of the problem

I've seen a couple of issue related to typescript icon imports #308 #237 #128. The solution was always to create the declaration yourself. This is where the library can be improved.

Suggested solution

After creating framework specific d.ts files, we could just add this comment in the actual project

/// <reference types="unplugin-icons/svelte" />
/// <reference types="unplugin-icons/vue" />
/// <reference types="unplugin-icons/jsx" />

just like with vite there is a vite-env.d.ts file with

/// <reference types="svelte" />
/// <reference types="vite/client" />

Alternative

No response

Additional context

No response

Validations

@eye-wave eye-wave added the enhancement New feature or request label Jan 13, 2025
@eye-wave
Copy link
Author

Nevermind, i just realized that this is already possible.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant