Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Test PR for the no-fork architecture #121

Closed
wants to merge 17 commits into from

Conversation

ulucinar
Copy link
Collaborator

Description of your changes

Fixes #

I have:

  • Read and followed Upbound's contribution process.
  • Run make reviewable to ensure this PR is ready for review.
  • Added backport release-x.y labels to auto-backport this PR, as appropriate.

How has this code been tested

@ulucinar ulucinar marked this pull request as draft October 19, 2023 17:04
@ulucinar
Copy link
Collaborator Author

/test-examples

@ulucinar
Copy link
Collaborator Author

/test-examples

2 similar comments
@ulucinar
Copy link
Collaborator Author

/test-examples

@ulucinar
Copy link
Collaborator Author

/test-examples

@ulucinar
Copy link
Collaborator Author

/test-examples

@ulucinar
Copy link
Collaborator Author

ulucinar commented Oct 20, 2023

Uptest run https://github.com/upbound/platform-ref-aws/actions/runs/6589825556/ will fail because one of the VPCs acquired the remove the crossplane.io/external-create-pending annotation status condition. We have disabled the async mode for VPC in these provider packages, planning to reenable it.

@ulucinar ulucinar closed this Oct 20, 2023
@ulucinar ulucinar reopened this Oct 20, 2023
@ulucinar
Copy link
Collaborator Author

/test-examples

1 similar comment
@ulucinar
Copy link
Collaborator Author

/test-examples

Signed-off-by: Alper Rifat Ulucinar <[email protected]>
@ulucinar
Copy link
Collaborator Author

/test-examples

@ulucinar
Copy link
Collaborator Author

/test-examples

@ulucinar
Copy link
Collaborator Author

/test-examples

1 similar comment
@ulucinar
Copy link
Collaborator Author

/test-examples

@ulucinar
Copy link
Collaborator Author

/test-examples

@ulucinar
Copy link
Collaborator Author

/test-examples

1 similar comment
@ulucinar
Copy link
Collaborator Author

/test-examples

@ulucinar
Copy link
Collaborator Author

/test-examples

@ulucinar
Copy link
Collaborator Author

/test-examples

1 similar comment
@ulucinar
Copy link
Collaborator Author

/test-examples

@ulucinar
Copy link
Collaborator Author

/test-examples

@ulucinar
Copy link
Collaborator Author

/test-examples

@ulucinar
Copy link
Collaborator Author

/test-examples

1 similar comment
@ulucinar
Copy link
Collaborator Author

/test-examples

@ulucinar
Copy link
Collaborator Author

/test-examples

@ulucinar
Copy link
Collaborator Author

ulucinar commented Nov 3, 2023

/test-examples

@haarchri
Copy link
Member

haarchri commented Nov 7, 2023

@ulucinar can you rebase when you running the tests again ? we released a new version of this platform-ref-aws v0.7.0

@ulucinar
Copy link
Collaborator Author

ulucinar commented Dec 13, 2023

Closing this PR as we've rolled the new architecture out in upbound/[email protected].

@ulucinar ulucinar closed this Dec 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants