Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor setup.py #315

Closed
KOLANICH opened this issue May 22, 2019 · 3 comments
Closed

refactor setup.py #315

KOLANICH opened this issue May 22, 2019 · 3 comments
Labels
duplicate
Milestone
dill-0.3.0

Comments

@KOLANICH
Copy link

KOLANICH commented May 22, 2019 •
edited
Loading

The code in setup.py is damn bad. It heavily needs refactoring.
1 remove all the large docstrings that can be read from files
2 stop constructing code and then executing it
3 use setup.cfg for storing metadata

Your setup.py should look like

from setuptools import setup
setup(use_scm_version = True)
@mmckerns
Copy link
Member

Duplicate of #114.

@mmckerns
Copy link
Member

Feel free to submit a PR.

@KOLANICH
Copy link
Author

OK

@mmckerns mmckerns added this to the dill-0.3.0 milestone Jun 26, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
duplicate
Projects
None yet
Milestone
dill-0.3.0
Development

No branches or pull requests
2 participants
@KOLANICH @mmckerns