Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Order of the variables is inverted in AutoFarm interface #15

Open
htadashi opened this issue Dec 30, 2021 · 0 comments
Open

Order of the variables is inverted in AutoFarm interface #15

htadashi opened this issue Dec 30, 2021 · 0 comments

Comments

@htadashi
Copy link
Contributor

In the interface the poolId is the last parameter https://github.com/defibasket/defibasket-contracts/blob/082e1d8507142b4311025b7f8f25c72fa418958a/contracts/bridges/interfaces/IAutofarmDeposit.sol#L20
but in the implementation is the first parameter: https://github.com/defibasket/defibasket-contracts/blob/082e1d8507142b4311025b7f8f25c72fa418958a/contracts/bridges/trusted/AutofarmDepositBridge/AutofarmDepositBridge.sol#L35

The same happens with withdraw function; we should change to the same order to avoid confusion in the future.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@htadashi