Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow users to manually abort #16

Open
payne911 opened this issue Mar 1, 2021 · 4 comments
Open

Allow users to manually abort #16

payne911 opened this issue Mar 1, 2021 · 4 comments
Labels
enhancement New feature or request

Comments

@payne911
Copy link
Collaborator

payne911 commented Mar 1, 2021

Potentially:

  • When reaching 80% of the remaining Rate Limited calls
  • Turn the "loading" button red and if clicked: abort

A proposed implementation was made there: #7 (comment)

@payne911 payne911 added enhancement New feature or request website labels Mar 1, 2021
@payne911
Copy link
Collaborator Author

Aborting all ongoing Promises isn't as trivial as I thought. There is a partial solution, but I'm still waiting on something that fulfills the 3 constraints listed there: https://stackoverflow.com/q/67086017/9768291

@payne911
Copy link
Collaborator Author

payne911 commented Feb 8, 2022

@micalevisk

Say I have 100 calls to make, and that after 70 I realize I need to stop. From what I understand, the AbortController indeed helps with avoiding the necessity to await the 70 calls to receive a response. But would it help with making sure that the following 30 requests that were supposed to be issued would get cancelled before being executed?

@micalevisk
Copy link

I didn't used AbortController API yet. But I guess each call could have its own abort signal, so you can invoke those controllers as you wish as long you track them properly

@payne911 payne911 removed the website label Jan 17, 2023
@payne911 payne911 added the help wanted Extra attention is needed label Jan 26, 2023
@payne911 payne911 removed the help wanted Extra attention is needed label Mar 25, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants