You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
This repository has been archived by the owner on May 16, 2022. It is now read-only.
I am using python versioning scheme in my python project (you don't say). Unfortunately release bot fails to parse it:
08:51:35.770 utils.py INFO Editing line with new version:
__version__ = "0.2.0.dev0"
08:51:35.770 utils.py WARNING Failed to validate version, aborting
08:51:35.771 utils.py ERROR No version files found. Aborting version update.
Honestly, I don't know how to tackle this one. We are using semver to compare versions and if semver fails to parse the version, the execution stops. One regex would not do, we would need a more sophisticated solution. Maybe there are already libraries which handle this situation.
The warning comes from update_version(), which uses semantic_version.validate() to make sure the version string we found in {'setup.py', '__init__.py', 'version.py'} is a proper semantic version string.
I think we don't need to be so strict in this case and just replace
ifsemantic_version.validate(old_version):
old_version->new_versionelse:
configuration.logger.warning(f"Failed to validate version, aborting")
with
try:
semantic_version.Version.coerce(old_version)
exceptValueError:
configuration.logger.warning(f"Failed to validate version, aborting")
else:
old_version->new_version
Sign up for freeto subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Labels
featureNew feature or a request for enhancement.help wantedExtra attention is needed
I am using python versioning scheme in my python project (you don't say). Unfortunately release bot fails to parse it:
Related #12 and all other versioning issues
The text was updated successfully, but these errors were encountered: