Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

readTextValueString does not support formed (\f). #2129

Closed
PaulKlint opened this issue Jan 25, 2025 · 3 comments
Closed

readTextValueString does not support formed (\f). #2129

PaulKlint opened this issue Jan 25, 2025 · 3 comments

Comments

@PaulKlint
Copy link
Member

Describe the bug

The formfeed character (denoted by \f) is not supported by readTextValueString.

To Reproduce

Steps to reproduce the behavior:

rascal>import ValueIO;
ok
rascal>readTextValueString("\"\\n\"");
value: "\n"
rascal>readTextValueString("\"\\f\"");
value: "102"         <=== expected: "\f"
@PaulKlint
Copy link
Member Author

It seems that StandardTextReader.readString does support \f.

A related observation: org.rascalmpl.values.parsetrees.SymbolFactory.char2int doesn't not support it (and I assume it should).

@DavyLandman
Copy link
Member

This bug has been fixed in the latest vallang, (see usethesource/vallang#268 and usethesource/vallang#270), fixed in this commid.

So I assume this was in a version of Rascal that was running an older version of vallang.

However, the org.rascalmpl.values.parsetrees.SymbolFactory.char2int is a omission.

@DavyLandman
Copy link
Member

Solved in #2135

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants