-
Notifications
You must be signed in to change notification settings - Fork 168
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
24.6.x gradle build : PWA icons generation failed #20842
Comments
Thanks for reporting. Could you please provide the complete exception stack trace? |
|
If you run with |
|
Unfortunately, it does not help that much. |
I tried also with the provided example code, but still cannot reproduce |
I was able to reproduce the failure but only after deletion of gradle caches ( Build failure
I could make it work by adding |
Icon generation is done in parallel, using common ForkJoin pool. |
@dominik42 can you drop gradle caches and run |
I can confirm the OOM Exception if run with --stacktrace
runs successfully. After omit the
the error occured again. My versions:
|
Description of the bug
Hi,
if I update my gradle based app from 24.5.8 to 24.6.x, the gradle build failed with the error
com.vaadin.flow.server.ExecutionFailedException: PWA icons generation failed
As default, my main application class (the one annotated with
@SpringBootAppplication
and@PWA
) does not define theiconPath
as parameter for the@PWA
annotation. Only if Isrc/main/resources/META-INF/resources/icons/icon.png
@PWA(name = "myApp" shortName = "myShortname" iconPath = "icons/icon.png")
the gradle build finished sucessfully.
Expected behavior
Also without declaring an iconPath explicetely, the build should finished successfully, as in prior vaadin flow versions as mentioned in https://vaadin.com/docs/latest/flow/configuration/pwa#icons
Minimal reproducible example
build.gradle:
src/main/java/de/test/MyApp.java
build with gradle:
./gradlew -Pvaadin.productionMode=true bootJar
Versions
The text was updated successfully, but these errors were encountered: