Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prototype Interfaces removal from autocomplete #161

Closed
yuriy-fix opened this issue Dec 7, 2023 · 3 comments
Closed

Prototype Interfaces removal from autocomplete #161

yuriy-fix opened this issue Dec 7, 2023 · 3 comments
Assignees

Comments

@yuriy-fix
Copy link

yuriy-fix commented Dec 7, 2023

As a part of this task we should prototype removal of Interfaces with cluttering properties / attributes from types while persisting the properties that are necessary for proper component behaviour.

We should also list the properties that are manually added back for future reference. It will also enable us to provide clarifications on the reasons of adding specific property.

@yuriy-fix yuriy-fix changed the title Prototype HTMLElement removal from autocomplete Prototype Interfaces removal from autocomplete Dec 7, 2023
@web-padawan
Copy link
Member

A few more properties to be removed: __cssBuild, _element and extends coming from ShadyCSS typings:

Screenshot 2023-12-07 at 12 19 11 Screenshot 2023-12-07 at 12 19 25

@tomivirkki
Copy link
Member

tomivirkki commented Dec 11, 2023

The issue will be fixed by #167

The PR also fixes #137, #150 and #165

We should also list the properties that are manually added back for future reference. It will also enable us to provide clarifications on the reasons of adding specific property.

Note that the PR does not exclude properties from HTMLElement that are also included in React.HTMLAttributes

From the omitted HTMLElement properties, only autofocus is currently manually added back, because some Vaadin web components also have autofocus property (and it's not included in React.HTMLAttributes)

@rolfsmeds
Copy link

Closing as fixed by #167

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants