Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ability to passthrough/ignore audio when rendering #227

Open
Prankejten opened this issue Nov 4, 2024 · 3 comments
Open

Ability to passthrough/ignore audio when rendering #227

Prankejten opened this issue Nov 4, 2024 · 3 comments
Labels
enhancement New feature or request

Comments

@Prankejten
Copy link

Currently when rendering in H264 mode, ntsc-rs re-encodes audio to 64kbps mono AAC in H264 mode and FLAC in FFV1 mode, and it would be really useful if you could enable passing through the audio (if the container format supports it) of the original video to the rendered video without re-encoding.

Additonally, the ability to exclude the audio track from the rendered video would be great considering that if you create a tape audio effect in an external program you won't need the audio ntsc-rs generates anyways.

You could add a dropdown selection menu in the render tab like so: (quick image I made)
ntsc-rs audio settings concept pic

@valadaptive valadaptive added the enhancement New feature or request label Nov 4, 2024
@valadaptive
Copy link
Owner

What video are you rendering? H.264 output is stereo for me.

@Prankejten
Copy link
Author

What video are you rendering? H.264 output is stereo for me.

Well then I'm not sure, I thought it converted stuff to mono, I guess I was wrong. But regardless, I mainly submitted this because the reencoded audio usually doesn't sound all that great (to me atleast), and I already chose the bitrate and such that I want when exporting the video from my editor, so audio passthrough would be more convenient. And again for the videos I spend more effort on, I use an external program for generating an audio effect so in that case ignoring the audio stream would be a nice addition.

@z0mb1e1fy
Copy link

YEAH PLEASE ADD THIS FEATURE

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

3 participants