Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CI: Node test "script kill unkillable test_" flaky #3065

Open
ikolomi opened this issue Feb 4, 2025 · 0 comments
Open

CI: Node test "script kill unkillable test_" flaky #3065

ikolomi opened this issue Feb 4, 2025 · 0 comments
Assignees
Labels
bug Something isn't working CI/CD CI/CD related Flaky-tests Flaky-tests node Node.js wrapper testing Everything about testing

Comments

@ikolomi
Copy link
Collaborator

ikolomi commented Feb 4, 2025

Describe the bug

Test failed on one mature configuration (6.2, ubuntu, x86) which most probably is a sign of flakiness:
https://github.com/valkey-io/valkey-glide/actions/runs/13127527442/job/36638451323#step:5:10981

  ● GlideClient › script kill unkillable test_1

    expect(received).toBeTruthy()

    Received: false

      1544 |                 }
      1545 |
    > 1546 |                 expect(foundUnkillable).toBeTruthy();
           |                                         ^
      1547 |             } finally {
      1548 |                 // If script wasn't killed, and it didn't time out - it blocks the server and cause the
      1549 |                 // test to fail. Wait for the script to complete (we cannot kill it)

      at tests/GlideClient.test.ts:1546:41
      at fulfilled (tests/GlideClient.test.ts:8:58)

It seems that test relies heavily on a timeouts, it might be the case that the settings are too strict.

Expected Behavior

test passes reliably

Current Behavior

test failed on one configuration during the full matrix test

Reproduction Steps

full matrix tests

Possible Solution

No response

Additional Information/Context

No response

Client version used

.

Engine type and version

.

OS

ubuntu

Language

TypeScript

Language Version

.

Cluster information

No response

Logs

No response

Other information

No response

@ikolomi ikolomi added bug Something isn't working CI/CD CI/CD related node Node.js wrapper testing Everything about testing labels Feb 4, 2025
@Yury-Fridlyand Yury-Fridlyand added the Flaky-tests Flaky-tests label Feb 4, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working CI/CD CI/CD related Flaky-tests Flaky-tests node Node.js wrapper testing Everything about testing
Projects
Status: No status
Development

No branches or pull requests

3 participants