Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

VDT does not capture COMBAT_LOG_EVENT_UNFILTERED args in 8.0. #7

Open
Hekili opened this issue Jul 30, 2018 · 0 comments
Open

VDT does not capture COMBAT_LOG_EVENT_UNFILTERED args in 8.0. #7

Hekili opened this issue Jul 30, 2018 · 0 comments

Comments

@Hekili
Copy link

Hekili commented Jul 30, 2018

Blizzard added a necessary function call to retrieve combat log args when COMBAT_LOG_EVENT_UNFILTERED fires: CombatLogGetCurrentEventInfo()

Here's a potential fix (Modules/ViragDevToolEvents.lua line 75):

function cleuHelper( args, ... )
    for i = 1, select( "#", ... ) do
        args[i+1] = select( i, ... )
    end
end


function ViragDevTool:SetMonitorEventScript()
    local f = self:GetListenerFrame()

    f:SetScript("OnEvent", function(this, ...)
        local args = { ... }
        local event = args[1]
		
        local showAllEvents = ViragDevTool:GetMonitoredEvent("ALL")
        if ViragDevTool:GetMonitoredEvent(event) or (showAllEvents and showAllEvents.active) then
            if event == 'COMBAT_LOG_EVENT_UNFILTERED' then cleuHelper( args, CombatLogGetCurrentEventInfo() ) end
            if #args == 1 then args = args[1] end
            ViragDevTool:Add(args, date("%X") .. " " .. event)
        end
    end);
end
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant