From 2268d7d13df92de4711fcaa632ed6b3c86876c2c Mon Sep 17 00:00:00 2001 From: Yolan Romailler Date: Wed, 14 Feb 2024 11:43:10 +0100 Subject: [PATCH] [n/a] Patching our Linter GHA (#2801) Signed-off-by: Yolan Romailler --- .github/workflows/golangci-lint.yml | 2 +- .golangci.yml | 3 ++- internal/cui/recipients.go | 1 - 3 files changed, 3 insertions(+), 3 deletions(-) diff --git a/.github/workflows/golangci-lint.yml b/.github/workflows/golangci-lint.yml index f64983d5a3..02d1dbdfdd 100644 --- a/.github/workflows/golangci-lint.yml +++ b/.github/workflows/golangci-lint.yml @@ -43,5 +43,5 @@ jobs: - name: golangci-lint uses: golangci/golangci-lint-action@3cfe3a4abbb849e10058ce4af15d205b6da42804 # v4.0.0 with: - version: latest # we have a list of linters in our .golangci.yml config file + version: v1.56.1 # we have a list of linters in our .golangci.yml config file only-new-issues: true diff --git a/.golangci.yml b/.golangci.yml index 81f2ffd3f8..63f4e6d54c 100644 --- a/.golangci.yml +++ b/.golangci.yml @@ -11,7 +11,7 @@ linters-settings: max-complexity: 22 skip-tests: true staticcheck: - go: "1.19" + go: "1.21" # https://staticcheck.io/docs/options#checks checks: ["all","-SA1019"] funlen: @@ -59,6 +59,7 @@ linters: - nolintlint - nosnakecase - paralleltest + - perfsprint - revive - rowserrcheck - scopelint diff --git a/internal/cui/recipients.go b/internal/cui/recipients.go index 34574f5883..9341f84135 100644 --- a/internal/cui/recipients.go +++ b/internal/cui/recipients.go @@ -130,7 +130,6 @@ func AskForGitConfigUser(ctx context.Context, crypto backend.Crypto) (string, st fmt.Sprintf("Use %s (%s) for password store git config?", name, email), true, ) - if err != nil { return "", "", err }