-
Notifications
You must be signed in to change notification settings - Fork 53
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
DLT function in Eigfree code #6
Comments
@Dangzheng Ping! |
Hi @kk1153 The normalization part seems unnecessary to me. The sign thing seems like it wants to keep z-axis's value to be positive. Did you try to disable these line and see what happens? Best regards, |
Can you please attach the script here? Else [email protected] . When I tried commenting this normalization, results do change. It would be great if you would be able to refer me to the source. |
So will this line influence the final results? @kk1153 |
@zjhthu I could not reproduce their results. Unfortunately, the synthetic dataset used for the evaluation was also not released by the authors. |
I am trying to modify the code as shown in this issue, the results seem acceptable though I only trained 10000 iterations. Still waiting for the finish of training. |
are you evaluating for PnP (pose estimation) or homography? PnP dataset was not released, right? |
I'm evaluating for the PnP problem, and generating data using the provided script. |
Why do you normalize 'v' by the norm of third row of rotation matrix specifically and also the sign in the below line?
https://github.com/Dangzheng/Eig-Free-release/blob/74cf782d54bfa57cc66ae81bf4f2f8309f25fd70/tests.py#L1164
The text was updated successfully, but these errors were encountered: