Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Epic] log_to_metric polishing #15332

Open
spencergilbert opened this issue Nov 23, 2022 · 1 comment
Open

[Epic] log_to_metric polishing #15332

spencergilbert opened this issue Nov 23, 2022 · 1 comment
Labels
domain: transforms Anything related to Vector's transform components Epic Larger, user-centric issue that contains multiple sub-issues transform: log_to_metric Anything `log_to_metric` transform related

Comments

@spencergilbert
Copy link
Contributor

Summary:

The log_to_metric transform continues to be a strong option for users wanting to reduce and control costs while still surfacing useful information in a more cost efficient way. However, the current UX of the transform is lacking and frequently raised as a point of confusion or overly verbose configuration.

A recent example of redundant tagging configuration:

I have to add the tags for each metric I extract, where it would be useful to have the tags added for all metrics extracted in the block.

[transforms.elb_to_metric]
type = "log_to_metric"
inputs = [ "split_on_status.ok" ]

  [[transforms.elb_to_metric.metrics]]
  type = "counter"
  field = "elb_status_code"
  name = "response_code_total"
  namespace = "elb"

    [transforms.elb_to_metric.metrics.tags]
    elb = "{{elb}}"
    user_agent = "{{user_agent}}"

  [[transforms.elb_to_metric.metrics]]
  type = "counter"
  field = "client_host"
  name = "client_host_total"
  namespace = "elb"

    [transforms.elb_to_metric.metrics.tags]
    elb = "{{elb}}"
    user_agent = "{{user_agent}}"

Related issues:

@spencergilbert spencergilbert added transform: log_to_metric Anything `log_to_metric` transform related domain: transforms Anything related to Vector's transform components Epic Larger, user-centric issue that contains multiple sub-issues labels Nov 23, 2022
@dogeahill
Copy link

This initial comment came from me, and while I do see the value in being able to add tags to each metric individually, the way it currently is written I would've expected those tags to be added to all metrics emitting from this transform.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
domain: transforms Anything related to Vector's transform components Epic Larger, user-centric issue that contains multiple sub-issues transform: log_to_metric Anything `log_to_metric` transform related
Projects
None yet
Development

No branches or pull requests

2 participants