Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Command line wallet leaves terminal input invisible upon Ctrl-C at the wrong time #10055

Closed
davidsiska-vega opened this issue Nov 13, 2023 · 3 comments · Fixed by #10860
Closed

Command line wallet leaves terminal input invisible upon Ctrl-C at the wrong time #10055

davidsiska-vega opened this issue Nov 13, 2023 · 3 comments · Fixed by #10860
Assignees
@ValentinTrinque
Labels
bug to-confirm
Milestone
⏭️ TBC

Comments

@davidsiska-vega
Copy link
Contributor

  1. Open the command line wallet: vegawallet service run --network mainnet1
  2. Make it ask for a password (e.g. because a website connects)
  3. Press Ctrl-C
  4. Type in the terminal e.g. ls - can you see it?
@davidsiska-vega davidsiska-vega added this to the ⏭️ TBC milestone Nov 13, 2023
@davidsiska-vega
Copy link
Contributor Author 

vegawallet software version
Software version:
v0.73.3

and

davidsiska$ uname -a
Darwin D-MBP-M1.local 22.6.0 Darwin Kernel Version 22.6.0: Thu Nov  2 07:43:57 PDT 2023; root:xnu-8796.141.3.701.17~6/RELEASE_ARM64_T6000 arm64

@gordsport gordsport moved this to Todo in Core Kanban Nov 14, 2023
@ValentinTrinque
Copy link
Contributor

Couldn't reproduce it so far.

Screenshot 2023-11-15 at 17 57 54

uname -a yields:

Darwin Sentinelle.local 22.6.0 Darwin Kernel Version 22.6.0: Wed Jul  5 22:22:05 PDT 2023; root:xnu-8796.141.3~6/RELEASE_ARM64_T6000 arm64

So we are basically on the same setup.

@ValentinTrinque
Copy link
Contributor

Tested with Alacritty 0.12.3 (1) and Terminal 2.13 (447)

@ValentinTrinque ValentinTrinque moved this from Todo to In Progress in Core Kanban Nov 15, 2023
@ValentinTrinque ValentinTrinque moved this from In Progress to Todo in Core Kanban Nov 15, 2023
@ValentinTrinque ValentinTrinque moved this from Todo to In Progress in Core Kanban Mar 11, 2024
@ValentinTrinque ValentinTrinque mentioned this issue Mar 11, 2024
Merged
@vega-issues vega-issues moved this from In Progress to Waiting Review in Core Kanban Mar 11, 2024
@vega-issues vega-issues moved this from Waiting Review to Approved in Core Kanban Mar 11, 2024
@github-project-automation github-project-automation bot moved this from Approved to Merged in Core Kanban Mar 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ValentinTrinque ValentinTrinque

Labels
bug to-confirm
Projects
Core Kanban
Archived in project
Milestone
⏭️ TBC
Development

Successfully merging a pull request may close this issue.

fix: Restore terminal state when quitting password input in wallet CLI vegaprotocol/vega
2 participants
@ValentinTrinque @davidsiska-vega