Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Estimate fees API Graph QL missing values #11696

Closed
JonRay15 opened this issue Sep 17, 2024 · 1 comment · Fixed by #11697
Closed

Estimate fees API Graph QL missing values #11696

JonRay15 opened this issue Sep 17, 2024 · 1 comment · Fixed by #11697
Labels

Comments

@JonRay15
Copy link

This party is one I know has volume discounts

query dealTicket {
  estimateFees(
    marketId:"90360cb6312346f8a5380cc7d6a7df30583135e743246d68ffd1a51effe7394e",
    partyId:"bba3b2283a00006ce531dbbb2b33e640c630ec8d9482aa8d4077fbdbb37c4fe4",
    price:"236900",
    size:"1000",
    timeInForce:TIME_IN_FORCE_GTC,
    side:SIDE_BUY,
    type:TYPE_MARKET
  )
  {
    totalFeeAmount
    fees{
      makerFee
      infrastructureFee
      liquidityFee
      buyBackFee
      treasuryFee
      highVolumeMakerFee
      makerFeeReferralDiscount
      makerFeeVolumeDiscount
      infrastructureFeeReferralDiscount
      infrastructureFeeVolumeDiscount
      liquidityFeeReferralDiscount
      liquidityFeeVolumeDiscount
      }
  }
}

but I am gettign NULLS back from all discount fields on the API.

{
  "data": {
    "estimateFees": {
      "totalFeeAmount": "1629850",
      "fees": {
        "makerFee": "459113",
        "infrastructureFee": "1147781",
        "liquidityFee": "22956",
        "buyBackFee": "",
        "treasuryFee": "",
        "highVolumeMakerFee": "",
        "makerFeeReferralDiscount": null,
        "makerFeeVolumeDiscount": null,
        "infrastructureFeeReferralDiscount": null,
        "infrastructureFeeVolumeDiscount": null,
        "liquidityFeeReferralDiscount": null,
        "liquidityFeeVolumeDiscount": null
      }
    }
  }
}
@vega-issues vega-issues moved this to Waiting Review in Core Kanban Sep 17, 2024
@vega-issues vega-issues moved this from Waiting Review to Approved in Core Kanban Sep 17, 2024
@github-project-automation github-project-automation bot moved this from Approved to Merged in Core Kanban Sep 17, 2024
@JonRay15 JonRay15 added api fe-request A list of reasonably high value API change requests from front end labels Sep 17, 2024
@JonRay15
Copy link
Author

JonRay15 commented Sep 18, 2024

This works.

It is missing high voulme maker fee but it cannot know that since it doesnt know who is on the othe side of the trade.

So it is done. Happy.

@JonRay15 JonRay15 removed the fe-request A list of reasonably high value API change requests from front end label Sep 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Archived in project
Development

Successfully merging a pull request may close this issue.

1 participant