-
Notifications
You must be signed in to change notification settings - Fork 1.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Passing the root workspace name as a package to --filter
does not work as expected
#9578
Comments
Only |
Ah that makes sense! Is there a way to declare a package graph dependency without that dependency being added to the package manager? In this situation I want a way to know if I need to run a root-level task when one of the dependencies of that task has changed. |
This can be closed. |
Currently |
Verify canary release
Link to code that reproduces this issue
https://github.com/dstaley/turborepo-root-filter
Which canary version will you have in your reproduction?
2.3.4-canary.2
Enviroment information
Expected behavior
turbo-ignore
correctly detects when the dependencies of a task defined for the root workspace have changed compared against themain
branch, and reports that the//#test:integration
task will be run.Actual behavior
The following error occurs:
To Reproduce
turbo-ignore --task test:integration --fallback main
Additional context
I believe passing the root workspace package name as
//
sort of works, but I'm not able to get it to correctly detect when a dependency has changed.To reproduce that,
main
packages/package-b/src/build.js
and commit it.npx turbo run "test:integration" --filter="//...[main]" --dry
Expected result:
Turbo reports that the
//#test:integration
,@repo/package-a#build
, and@repo/package-b#build
tasks will be run.The text was updated successfully, but these errors were encountered: