Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

We are saving this in the db, but are we ever using this value from the db? #25

Open
tapishr opened this issue Oct 26, 2023 · 0 comments
Open

We are saving this in the db, but are we ever using this value from the db? #25

tapishr opened this issue Oct 26, 2023 · 0 comments
Assignees
@tapishr

Comments

@tapishr
Copy link
Member

tapishr commented Oct 26, 2023 

          We are saving this in the db, but are we ever using this value from the db?

I think we should use it as the 1st default value in this function itself if config was not sent in the message_data; and default to the RepoConfig::default() only when this information is not available in the db.

Originally posted by @avikalpg in #11 (comment)
@tapishr tapishr self-assigned this Oct 26, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@tapishr tapishr

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@tapishr