Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

TimeoutError #3

Open
jleibund opened this issue Feb 6, 2017 · 1 comment
Open

TimeoutError #3

jleibund opened this issue Feb 6, 2017 · 1 comment

Comments

@jleibund
Copy link

jleibund commented Feb 6, 2017

It seems sometimes I'm getting a greenado.concurrent.TimeoutError from a gyield... but other times a tornado.gen.TimeoutError.

Any chance greenado TimeoutError could just inherit from tornado TimeoutError?
@virtuald
Copy link
Owner

virtuald commented Feb 6, 2017

The reason that wasn't done is because TimeoutError was introduced in Tornado 4.0, and there wasn't a good reason to break compatibility with Tornado 3.x. I suspect Tornado 3.x is seldom used now, so I would accept a PR that makes this change and updates the dependencies.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@virtuald @jleibund