Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature Request: Improve VStream Error Messages #17548

Open
twthorn opened this issue Jan 15, 2025 · 0 comments · May be fixed by #17558
Open

Feature Request: Improve VStream Error Messages #17548

twthorn opened this issue Jan 15, 2025 · 0 comments · May be fixed by #17558
Assignees
Labels
Component: VReplication Type: Enhancement Logical improvement (somewhere between a bug and feature)

Comments

@twthorn
Copy link
Contributor

twthorn commented Jan 15, 2025

Feature Description

VStream errors often are not clear what occurred and which components of the system were involved (eg which vtgate, vttablet). Some examples of these errors are:

Exception status: Status{code=UNKNOWN, description=target: <keyspace>.c0-.replica: vttablet: rpc error: code = Unknown desc = EOF, cause=null}
unexpected server eof

Here are a possibilities to improve the information sent in VStream errors:

  1. Include the tablet hostname (many times the issue is with the specific mysql/host so this is the first step of debugging)
  2. Return the original mysql error (often checking mysql error.log returns the actual root cause). There may be cases we obfuscate these errors

Use Case(s)

Helps operators of VStream clients to debug/fix things

@twthorn twthorn added the Needs Triage This issue needs to be correctly labelled and triaged label Jan 15, 2025
@twthorn twthorn changed the title Feature Request: Improve VStream Error Visibility Feature Request: Improve VStream Error Messages Jan 15, 2025
@mattlord mattlord self-assigned this Jan 16, 2025
@mattlord mattlord added Component: VReplication Type: Enhancement Logical improvement (somewhere between a bug and feature) and removed Needs Triage This issue needs to be correctly labelled and triaged labels Jan 16, 2025
@github-project-automation github-project-automation bot moved this to Backlog in VReplication Jan 16, 2025
@mattlord mattlord moved this from Backlog to In progress in VReplication Jan 16, 2025
@mattlord mattlord linked a pull request Jan 16, 2025 that will close this issue
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Component: VReplication Type: Enhancement Logical improvement (somewhere between a bug and feature)
Projects
Status: In progress
Development

Successfully merging a pull request may close this issue.

2 participants