Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Graceful shutdown hangs when I use a Chromium based browser #138

Closed
czy-29 opened this issue May 9, 2024 · 4 comments
Closed

Graceful shutdown hangs when I use a Chromium based browser #138

czy-29 opened this issue May 9, 2024 · 4 comments

Comments

@czy-29
Copy link

czy-29 commented May 9, 2024

This problem of Viz is exactly the same as Axum:
tokio-rs/axum#2611

This is due to a bug in hyper-util:
issue: hyperium/hyper#3576
pr: hyperium/hyper-util#101

Patching hyper-util in Cargo.toml like this also works for viz:

[patch.crates-io]
hyper-util = { git = "https://github.com/hyperium/hyper-util.git", rev = "a77d866ff65a68ea5d048d058108552c39ec470d" }

The reason for posting the same issue here in Viz is that when hyper-util is finally updated, I hope we can follow up with the updated version in time, so that I can remove such a temporary patch and update to the latest version.

@fundon
Copy link
Member

fundon commented May 11, 2024

Thanks for the feedback. I will fix this ASAP.

@czy-29
Copy link
Author

czy-29 commented May 26, 2024

hyper-util 0.1.4 is released!
https://crates.io/crates/hyper-util/0.1.4
We should update as soon as possible and finally close this issue.

@fundon
Copy link
Member

fundon commented May 26, 2024

Nice! Let's ship it.

@fundon
Copy link
Member

fundon commented May 28, 2024

Landed in v0.8.5.
Thanks.

@fundon fundon closed this as completed May 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants