Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix subset errors for bar plot #3

Open
raprasad opened this issue Aug 14, 2017 · 2 comments
Open

fix subset errors for bar plot #3

raprasad opened this issue Aug 14, 2017 · 2 comments

Comments

@raprasad
Copy link
Collaborator

raprasad commented Aug 14, 2017

The following sequence is causing errors in the JS console (Chrome/Mac)

  1. Start the app (e.g. opens fearonLaitin)
  2. Subset a variable bar plot variable; choose a 5-10 countries from country
  3. Ajax call succeeds but errors in redrawing similar to below:

developer_tools_-_file____users_ramanprasad_documents_github-rp_pull_tests_tworavens_index_html

apparent cause

I'm getting similar results for the older TwoRavens in production.

The subset is too narrow and preprocess marks all the variables as valid = 0

fix

Some type of message is needed for the user.

  • communicate that the subset is too narrow and doesn't contain enough data for calculations?
  • needs a message in the JSON coming from Rook
@raprasad
Copy link
Collaborator Author

raprasad commented Aug 14, 2017

(moved to main issue)

@raprasad
Copy link
Collaborator Author

raprasad commented Aug 14, 2017

(moved to main issue)

kripanshu added a commit that referenced this issue Aug 16, 2017
kripanshu added a commit that referenced this issue Aug 16, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant