-
Notifications
You must be signed in to change notification settings - Fork 24
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Automatically generate app icons #8
Comments
@jbmoelker hey, thanks for making the issue I tried icon-gen for this and the problem i had was that when you pull images from manifest.json they were not the correct size. We might need to resize the images from the manifest into proper size to match the table given here: https://github.com/akabekobeko/npm-icon-gen#png |
@vladikoff yes experienced the same issue. I'd say we pick the largest size from the manifest and resize that for all the missing sizes. But honestly I also made a copy of |
It appears we need to first look at icon type. If that's not defined we need to fetch the icon and read the headers to determine the type. Which types do we want to support (PNG, SVG, JPG?, WebP?)? Sizes can be a list of space separated {w}x{h} values. We'll also need to parse all of those to see which are the best icon images to use. The excerpt below gives an idea of different icon notations:
(btw: just writing this out to get a good understanding of what's required for auto generating platform icons. I find inadequate PRs more wasteful) |
There is nothing like |
Currently you need to create app icons for each platform manually using something like iconverticons.com/online/ (as described in README).
It would be great if these app icons would be generated automatically based on the icons defined in the
manifest.json
. I have good experience on OSX withnpm-icon-gen
. I could help add this to the tool, if there's interest for it.The text was updated successfully, but these errors were encountered: