-
-
Notifications
You must be signed in to change notification settings - Fork 6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Feature]: support image_embeds in openai api as well #13540
Comments
|
Actually, never mind. |
Prefix caching is already done automatically in V1. Is there a particular benefit of sending the embeddings over HTTP? |
it is super useful for us so that we can experiment image embeddings via other inference engine or service without porting any image encoder implementation in vllm. Yes. I think if we can send it via
|
I don't think this is an unreasonable ask for experimentation but at the same time I'm not sure if it's a good idea to deviate too much from the standard OpenAI API on our frontend server, so this is probably something we can add but not recommend. IMHO if you indeed want to send in multimodal embeddings as input (which makes a lot of sense for a large scale deployment where you want to process/generate embeddings separately), it's probably better to build your own API server on top of AsyncLLM, and we can indeed open up an interface for you to pass in your own hashes/identifer of embeddings. |
@ywang96 thanks for your reply. But creating another api seems to be a bit of duplication. And I also observed that openai/protocol.py from vllm supports non standard openai arguments as well via |
That's true, but what you're proposing is passing the embeddings directly to the |
Hi, @DarkLight1337 Can i pick up this issue? video_messages = [
{"role": "system", "content": "You are a helpful assistant."},
{"role": "user", "content": [
{
"type": "image_embeds",
"image_embeds": "data:image/embeds;base64,{base64_image}",
}],
},
] |
Sure, thanks!
Yes, but I guess we should just pass the embeddings directly instead of having to parse it out of the URL |
@chaunceyjiang @DarkLight1337 thanks a lot |
I have submitted a PR #13955. To be honest, I don't know if it meets your needs. @gyin94 Could you give me an example code for using openAI? For example, using this image My implementation is based on this. |
🚀 The feature, motivation and pitch
would it be possible to support
image_embeds
in openai protocol api as well? And prefix-caching shall be supported via following proposal. thanks.So users can pass
use base64 or other more efficient compression method?
cc @youkaichao
Alternatives
No response
Additional context
No response
Before submitting a new issue...
The text was updated successfully, but these errors were encountered: