Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clean up leaked CSI snapshot for incomplete backup #8637

Merged
merged 1 commit into from
Jan 23, 2025

Conversation

reasonerjt
Copy link
Contributor

This commit makes sure when a backup is deleted the controller will delete the CSI snapshot even when the bakckup tarball is not uploaded.

fixes #8160

Thank you for contributing to Velero!

Please add a summary of your change

Does your change fix a particular issue?

Fixes #(issue)

Please indicate you've done the following:

Copy link

codecov bot commented Jan 22, 2025

Codecov Report

Attention: Patch coverage is 70.00000% with 6 lines in your changes missing coverage. Please review.

Project coverage is 59.39%. Comparing base (5b1738a) to head (1c37289).
Report is 5 commits behind head on main.

Files with missing lines Patch % Lines
pkg/controller/backup_deletion_controller.go 70.00% 4 Missing and 2 partials ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #8637      +/-   ##
==========================================
+ Coverage   59.33%   59.39%   +0.06%     
==========================================
  Files         370      370              
  Lines       39932    39970      +38     
==========================================
+ Hits        23692    23742      +50     
+ Misses      14744    14736       -8     
+ Partials     1496     1492       -4     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

This commit makes sure when a backup is deleted the controller will
delete the CSI snapshot even when the bakckup tarball is not uploaded.

fixes vmware-tanzu#8160

Signed-off-by: Daniel Jiang <[email protected]>
@reasonerjt reasonerjt merged commit bedea9c into vmware-tanzu:main Jan 23, 2025
46 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Cleanup of Leaked Snapshot due to Velero Pod Restart while backup is In-Progress
5 participants