Skip to content
This repository has been archived by the owner on Feb 16, 2021. It is now read-only.

Any chance of merging my derived library #29

Open
thekalinga opened this issue Jun 2, 2017 · 2 comments
Open

Any chance of merging my derived library #29

thekalinga opened this issue Jun 2, 2017 · 2 comments

Comments

@thekalinga
Copy link

thekalinga commented Jun 2, 2017

I have created a derived library from this project long back with quite a lot of additions to this library. I believe its feature complete (support for oauth2 refresh token flows, handling errors, unsubscription, ability to generate mock response/shortcuit, e.t.c)

Here is the link to the library.
https://github.com/1tontech/x-ng4-http-interceptor-dontuse

& corresponding demo for all almost all features is here.

https://github.com/1tontech/x-ng4-http-interceptor-dontuse-demo

However, I don't have time to maintain any bugs that might arise.

I wanted to check with you if you would be interested in merging the code into this project :)

Please let me know your opinion on this?

@thekalinga thekalinga changed the title Any plans on using the derived library (almost a library of its own) Any plans on merging the derived library (almost a library of its own) Jun 2, 2017
@thekalinga thekalinga changed the title Any plans on merging the derived library (almost a library of its own) Any plans on merging the derived library Jun 2, 2017
@thekalinga thekalinga changed the title Any plans on merging the derived library Any plans on merging my derived library Jun 2, 2017
@thekalinga thekalinga changed the title Any plans on merging my derived library Any chance of merging my derived library Jun 2, 2017
@TheCodeDestroyer
Copy link

@thekalinga Do you mind if I use your npm until this is merged?
It does work with ng4, right?

@thekalinga
Copy link
Author

thekalinga commented Jun 14, 2017

@TheCodeDestroyer Yes. Please check the demo before your try it out. No warranties however :).

If there are issues (which I hope not, as demo addresses most of the scenarios), I might not fix it unless its a critical bug, as I am quite occupied with my own work (which is why I created this ticket to begin with)

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants