New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Useless version checking #2

Open

vonorfasyexela opened this issue Sep 19, 2019 · 0 comments

Labels

invalid

Owner

vonorfasyexela commented Sep 19, 2019

In this part of Hello World:

// the flag to estimate the size difference of resulting binary
#ifdef FULL_OPENCV
#include <opencv2/opencv.hpp>
#else
#if (CV_MAJOR_VERSION < 3)
#include <opencv2/core/core.hpp>
#else
#include <opencv2/core.hpp>
#endif // (CV_MAJOR_VERSION < 3)
#include <iostream>
#endif // FULL_OPENCV
#include <regex>

... CV_MAJOR_VERSION checking is useless as long as this macros is not declared at that line.

The text was updated successfully, but these errors were encountered:

vonorfasyexela added the invalid label

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment