if relayhost is defined, then use the satellite profile #310
Conversation
kenyon
changed the title
| @@ -334,12 +334,11 @@ | |||
| end | |||
| end | |||
| context 'when mta is enabled' do | |||
| let(:params) { { mta: true, mydestination: '1.2.3.4', relayhost: '2.3.4.5' } } | |||
There was a problem hiding this comment.
Why remove?
Also, I think testing should be added to verify the intended behavior.
There was a problem hiding this comment.
Whith this change, $relayhost become like $satellite. So as you can't have $satellite and $mta define in the same time, you can't have $relayhost and $mta in same time.
When you use the mta profile whit the relayhost, there is two correct way to do it :
- being call by satellite profile
- being call directly
So this change is necessary to made test working.
There was a problem hiding this comment.
Since these items are mutually exclusive, there should be a test for them that shows the module fails as expected if they are both set.
Co-authored-by: Kenyon Ralph <[email protected]>
Allow parameter smtp_listen to accept multiple IPs
|
I have made the necessary modification in the documentation and in the error message. |
Parameters used for generating resources should be plural. Remove incorrect usage of Optional. Also, use loops instead of `create_resources()`.
The `regexp` map type is similar to the `pcre` type in that it doesn't need a database generated by `postmap`. Also some cleanup of the parameter formatting.
Tests for wrong parameter data types aren't really needed since Puppet will do the type checking itself. These tests also caused warnings because they didn't provide specific error messages to the `raise_error` matcher. Also, provide error messages to the remaining `raise_error` matches that lacked error messages, to avoid warnings like this: WARNING: Using the `raise_error` matcher without providing a specific error or message risks false positives, since `raise_error` will match when Ruby raises a `NoMethodError`, `NameError` or `ArgumentError`, potentially allowing the expectation to pass without even executing the method you are intending to call. Actual error raised was a Resource Statement, Postfix::... expects a match for Enum['absent', 'present'], got Tuple (line: 5) on node lithium.kenyonralph.com>. Instead consider provi ding a specific error class or message. This message can be suppressed by setting: `RSpec::Expectations.configuration.on_potential_false_positives = :nothing`. Called from /home/kenyon/git/ puppet-postfix/spec/defines/postfix_virtual_spec.rb:88:in `block (5 levels) in <top (required)>'.
…tional-usage init.pp: correct param numbers and use of optional
allow creation of postfix::map resources with hiera
map: handle regexp type
remove unneeded tests; provide error message for raise_error
Comply to rubocop 1.22.3
For CentOS 9 and RHEL 9 the `mailx` and `mail` commands are provided by the package `s-nail` rather than `mailx`. For information: https://www.sdaoden.eu/code.html#s-nail
Declare CentOS 9 Support, Install s-nail on 9
…November of 2032. It does not appear to have breaking changes. It would be nice for the dependencies on the Postfix module to reflect the latest versions.
increase dependency of puppet/alternatives to next major version
| @@ -334,12 +334,11 @@ | |||
| end | |||
| end | |||
| context 'when mta is enabled' do | |||
| let(:params) { { mta: true, mydestination: '1.2.3.4', relayhost: '2.3.4.5' } } | |||
There was a problem hiding this comment.
Since these items are mutually exclusive, there should be a test for them that shows the module fails as expected if they are both set.
Add switches for simple domain masquerade
modulesync 5.2.0
Release 3.0.0
Fixes variable typos that has been added with Pull Request 326. This is just cosmetic since this values are also pick_default inside postfix::mta and does result to the same catalog on the systems.
Because pick_default converts undef to an empty string we need to use lest here as a work around. https://tickets.puppetlabs.com/browse/MODULES-6534 For datatype consistency we also change it in the manifests/mta.pp.
Fix typos errors in postfix::satellite from PR 326
|
Dear @kapouik, thanks for the PR! This is Vox Pupuli Tasks, your friendly Vox Pupuli GitHub Bot. I noticed that your pull request contains merge conflict. Can you please rebase? You can find my sourcecode at voxpupuli/vox-pupuli-tasks |
Co-authored-by: Kenyon Ralph <[email protected]>
|
It looks like that branch got somewhat messed-up for some times. I will close this PR for now, but feel free to submit a cleaned-up version if you want your change to be upstreamed. |
Pull Request (PR) description
when relayhost is define in the init.pp, there is nothing call behind it. As it, if you use it like show in the documentation, it don't work.
After reading the code, it look like that the standard usage for relayhost is to use satellite profile that permit to configure postfix to send all email to $relayhost.
This Pull Request (PR) fixes the following issues
Fixes #295