Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for RHEL/CentOS 8 #816

Open
siebrand opened this issue Oct 22, 2019 · 6 comments · May be fixed by #1027
Open

Add support for RHEL/CentOS 8 #816

siebrand opened this issue Oct 22, 2019 · 6 comments · May be fixed by #1027
Labels
enhancement New feature or request

Comments

@siebrand
Copy link

The module is currently not supported on RHEL/CentOS 8. Please add support for those os versions.

@wyardley wyardley added the enhancement New feature or request label Dec 2, 2019
@wyardley
Copy link
Contributor

wyardley commented Dec 2, 2019

Are you able to make a PR to add or test this functionality?

@siebrand
Copy link
Author

siebrand commented Dec 2, 2019

As far as I can tell, it would be as easy as adding version 8 to RHEL/CentOS in metadata.json. No way for me to prove this yet, though.

@wyardley
Copy link
Contributor

wyardley commented Dec 2, 2019

If you can test / verify that it functions as-is, without any additional code changes, feel free to PR that. We'll need to make sure that it gets auto-added to the travis matrix just from that change so that at least acceptance tests are being run there.

@rehan2908
Copy link

When will the support for Centos 8 be added. Erlang Repo URL needs to be changed then

@timmooney
Copy link

What's the blocker on this issue?

RHEL 8 is about half way through its lifecycle, and RHEL 9 has been out for more than a year.

FYI I'm using puppet-rabbitmq 12.1.0 on RHEL 9.1 with puppet 6.x (which is also now EOL) and as far as I can tell it's working just fine.

@wyardley
Copy link
Contributor

wyardley commented Mar 4, 2023

Hi - the blocker really relates to integration tests and some of the issues with bootstrapping erlang, as well as the discussions around switching back to having the RabbitMQ built packages as default again (with the default of repos_ensure).

I agree that it should probably work, esp. with the right settings around getting erlang setup and choosing which rabbitmq package to get.

But, someone will probably need to take it on themselves to make one or more PRs to get some of the above working before Vox can "officially" support those versions (and test them properly in CI)

wyardley added a commit to wyardley/puppet-rabbitmq that referenced this issue May 20, 2024
Note: CentOS 8 has been EOL for a while, and RHEL 8 is EOL at the end of
May, 2024. Thus, official support may be dropped again soon

Fixes voxpupuli#942
Closes voxpupuli#900
Fixes voxpupuli#816
wyardley added a commit to wyardley/puppet-rabbitmq that referenced this issue May 20, 2024
Note: CentOS 8 has been EOL for a while, and RHEL 8 is EOL at the end of
May, 2024. Thus, official support may be dropped again soon

Fixes voxpupuli#942
Closes voxpupuli#900
Fixes voxpupuli#816
wyardley added a commit to wyardley/puppet-rabbitmq that referenced this issue Nov 17, 2024
- Remove support for CentOS / RHEL 7 (breaking change)
- Remove workarounds specific to EPEL and require_epel parameter (breaking change)
- Add support for CentOS / RHEL 9 in metadata
- Where repos_ensure is not set, install centos-release-rabbitmq-38 to
  support installing RabbitMQ from semi-official source
- Add in some additional tests for coverage (followup to voxpupuli#1028) that
  were hard to test without a supported RedHat family OS in metadata

Fixes voxpupuli#816

Signed-off-by: William Yardley <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
4 participants