UI didn't show message completely

[SheenArtem]

Reproduce: (while computer has no internet.)
win_sparkle_init(); win_sparkle_check_update_with_ui();

WinSparkle version is 0.8.0
Windows 11 22H2
DPI is 100%
Language = zh_TW

But it's normal while language is en_us, the message window is expended and larger.

The message is:
#: src/ui.cpp:801
msgid "An error occurred in retrieving update information; are you connected to the internet? Please try again later."
msgstr "擷取更新資訊時遭遇錯誤，您是否已連結到網際網路？請稍後重試。"

[vslavik]

You forgot to include basic information like WinSparkle or Windows version. Ideally reproduction instructions in the included example app too...

[brokensword2018]

Reproduce: (while computer has no internet.) win_sparkle_init(); win_sparkle_check_update_with_ui();

WinSparkle version is 0.8.0 Windows 11 22H2 DPI is 100% Language = zh_TW

But it's normal while language is en_us, the message window is expended and larger.

The message is: #: src/ui.cpp:801 msgid "An error occurred in retrieving update information; are you connected to the internet? Please try again later." msgstr "擷取更新資訊時遭遇錯誤，您是否已連結到網際網路？請稍後重試。"

have you solve this. I have meet the same issue. @SheenArtem

@vslavik the problem is error msg in zh_CN/zh_TW does not show completely. you can reproduce by setting the language to zh_CN or zh_TW.

word wrap happen in english while no word wrap in zh_CN/zh_TW

[hoozh]

I think the problem is in wxWidgets:

https://github.com/wxWidgets/wxWidgets/blob/a812fffda3fe686c94e24bff27e8effd96e4de64/src/common/stattextcmn.cpp#L145

// Find the last word to chop off.
const size_t lastSpace = line.rfind(' ', posEnd);
if ( lastSpace == wxString::npos )
{
    // No spaces, so can't wrap.
    DoOutputLine(line);
    break;
}

The message wrapping is implemented by looking for a space character, but there is no space character in the Chinese translation

[vslavik]

@hoozh The problem is not that the text is not wrapped — that should have resulted in a wide window (and could be tweaked to look nicer by adding a hard newline to the translation). The problem is that the non-wrapped text is cut-off.¹

Footnotes

1. FWIW, I think that's unlikely to be wxWidgets' fault, but rather mine in some sizing code. ↩