Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Restore margin parameter to find_adversarial_example #160

Open
vtjeng opened this issue Mar 14, 2024 · 0 comments
Open

Restore margin parameter to find_adversarial_example #160

vtjeng opened this issue Mar 14, 2024 · 0 comments
Labels
feature request good first issue help wanted

Comments

@vtjeng
Copy link
Owner

vtjeng commented Mar 14, 2024

Adding a margin would enable users to ensure that the target category has logits strictly larger than any non-target category, accounting for solver tolerances. For more details, see #158 (comment).

Sketch

  • Ensure that margin is applied in all solve modes (closest; worst).
  • Add tests that fail at HEAD and pass with the new behavior. It would probably be best to use a simple NN.

NOTE: This would partially undo #65.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
feature request good first issue help wanted
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@vtjeng