Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Address many “TODO” comments (and friends) in checklink #69

Open
Zearin opened this issue Aug 13, 2023 · 0 comments
Open

Address many “TODO” comments (and friends) in checklink #69

Zearin opened this issue Aug 13, 2023 · 0 comments

Comments

@Zearin
Copy link
Contributor

Zearin commented Aug 13, 2023

Below is a list of the various comments with the TODO, FIXME, XXX, or (sometimes) @@@ markers in checklink.

Specifics of how I got this list

I generated the list with the following command:

grep --ignore-case --line-number --extended-regexp  '#\s*(@@@|todo|fixme|xxx|@@@)'  ./bin/checklink

There are a few results that may not be intended as “todo” items, but were nevertheless marked with a matching pattern. I left these results in, just in case people who know more than I do might interpret/scrutinize them differently.

I added links to the line numbers for convenience.

List of TODO (and friends) comments

  • 128: # @@@ Why not just $self->SUPER::simple_request?
  • 146: # @@@ TODO: when an LWP internal robots.txt request gets redirected,
  • 233: # @@@ Needs also W3C::UserAgent but can't use() it here.
  • 470: my $ua = W3C::UserAgent->new($AGENT); # @@@ TODO: admin address
  • 631: # @@@ Ignore invalid depth silently for now.
  • 1794: # @@@ subtract robot delay from the "fetched in" time?
  • 2074: # @@@@ In XHTML, <a name="foo" id="foo"> is mandatory
  • 2118: # @@@TODO: The reason for handling <base href> ourselves is that LWP's
  • 2148: # TODO: HTML 4 spec says applet/@codebase may only point to
  • 2267: # FIXME: are there CSS rules with URLs that aren't mixed content blockable?
  • 2326: # TODO: Check the rules defined in
  • 2402: # TODO: find content types for which fragment are defined
  • 2413: # @@@TODO: this isn't the best thing to do if a decode error occurred
  • 2431: # TODO #top is OK in HTML documents
  • 3343: { # XXX no easy way to check if cookie expired?
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant