From a9f216070c2ee34d0264094e034ed4a0af1fd860 Mon Sep 17 00:00:00 2001 From: Benjamin Young Date: Wed, 14 Aug 2024 14:44:07 -0400 Subject: [PATCH] Add note about section 11.1 covered by 4.6. Multiple language usage is optional, so these MAY be expanded later if/as needed. --- tests/4-6-names-and-descriptions.js | 7 +++++++ tests/50-advanced-concepts.js | 3 --- 2 files changed, 7 insertions(+), 3 deletions(-) diff --git a/tests/4-6-names-and-descriptions.js b/tests/4-6-names-and-descriptions.js index 381061a..d08b4f3 100644 --- a/tests/4-6-names-and-descriptions.js +++ b/tests/4-6-names-and-descriptions.js @@ -24,6 +24,13 @@ const {match} = filterByTag({tags: [tag]}); // appear anywhere. However, we have tests for them (on `issuer` so far), so // keeping them in play seems prudent/useful. They can be expanded later also // to cover `name` and/or `description` anywhere they appear. + +// Also, the normative section... +// 11.1 Language and Base Direction https://w3c.github.io/vc-data-model/#language-and-base-direction +// ...is partially covered by these tests. A more complete approach would test +// any occurance of a "Value Object" (detecting `@value` throughout the tree) +// and test for conformat member properties (`@language` and `@direction`) and +// fail on the existence of any other properties. describe('Names and Descriptions', function() { setupMatrix.call(this, match); for(const [name, implementation] of match) { diff --git a/tests/50-advanced-concepts.js b/tests/50-advanced-concepts.js index 276f8f8..f45de34 100644 --- a/tests/50-advanced-concepts.js +++ b/tests/50-advanced-concepts.js @@ -151,6 +151,3 @@ describe('Advanced Concepts', function() { // 7.2 Problem Details https://w3c.github.io/vc-data-model/#problem-details // TODO: optionaly response format; but we could write tests for it - -// 11.1 Language and Base Direction https://w3c.github.io/vc-data-model/#language-and-base-direction -// TODO: possibly already covered by Name and Description tests