Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add display hints to data model, for example: information to use a Web Component #42

Closed
dlongley opened this issue Mar 10, 2017 · 15 comments
Assignees

Comments

@dlongley
Copy link
Contributor

dlongley commented Mar 10, 2017

We should consider having something in the data model that specifies how to display a credential in a consistent way, for example, a link to a Web Component for rendering a verifiable claim/credential. This would allow independent displayers of VCs to be able to pull in custom components for rendering claims/credentials in specific and consistent ways.

Note that there are privacy concerns related to this -- as when displayers request custom component HTML it will leak information (i.e. that the displayer wants to display that particular type of VC ... and we need to be careful that this doesn't uniquely identify someone). There are also security issues -- users getting fooled by displays that misrepresent the credential information.

@dlongley dlongley added privacy-tracker Group bringing to attention of Privacy, or tracked by the Privacy Group but not needing response. security-tracker Group bringing to attention of security, or tracked by the security Group but not needing response. labels Mar 10, 2017
@dlongley
Copy link
Contributor Author

We need to talk to Web App Sec about how we can sandbox third party Web Components that are used to display Verifiable Claims ... so we can prevent them from using the network (and potentially other things).

@liamquin
Copy link

liamquin commented Oct 3, 2017

Rendering a claim would involve additional items in the dm i think, to mark natural language (and there are security implications, making sure the text alternative is a correct translation).

@dlongley
Copy link
Contributor Author

dlongley commented Oct 3, 2017

@dlongley dlongley changed the title Integration with Web Components Add display hints to data model, for example: Integration with Web Components Nov 28, 2017
@dlongley dlongley changed the title Add display hints to data model, for example: Integration with Web Components Add display hints to data model, for example: information to use a Web Component Nov 28, 2017
@dlongley
Copy link
Contributor Author

Other security issues include showing displays to users that do not accurately represent the verifiable credential.

@dlongley
Copy link
Contributor Author

cc: @stonematt, @ottonomy, @kimdhamilton

@msporny
Copy link
Member

msporny commented Feb 13, 2018

This issue seems like it's at risk for not being included in 1.0. Someone needs to propose some spec text or an example where we specify a display template / package.

If we don't have something by CR, we'll have to close this issue.

@David-Chadwick
Copy link
Contributor

+1 for closing this issue.

@dlongley
Copy link
Contributor Author

I don't think we can deal with this in 1.0 -- we should close it or mark it as future work if that's a thing we're doing.

@kdenhartog
Copy link
Member

We discussed this on the call and decided to defer this to V2. It's just a placeholder for that

@kdenhartog kdenhartog added defer-v2 and removed defer labels Aug 11, 2021
@iherman
Copy link
Member

iherman commented Aug 12, 2021

The issue was discussed in a meeting on 2021-08-11

  • no resolutions were taken
View the transcript

4.3. Add display hints to data model, for example: information to use a Web Component (issue vc-data-model#42)

See github issue #42.

Wayne Chang: dlongley can you talk about this one

Dave Longley: we've already said this may be part of V2

Wayne Chang: we can move that to V2

Wayne Chang: #57

Wayne Chang: add roles to data model for next draft sounds V2

Kyle Den Hartog: +1

Manu Sporny: we've tried really hard to keep the language constrained, we don't want to open that up again. I think we should close.

David Chadwick: close it

Wayne Chang: I'm fine with closing, any objections?

@brentzundel brentzundel added relevant? and removed privacy-tracker Group bringing to attention of Privacy, or tracked by the Privacy Group but not needing response. security-tracker Group bringing to attention of security, or tracked by the security Group but not needing response. v2.0 labels Jul 26, 2022
@msporny
Copy link
Member

msporny commented Aug 10, 2022

@msporny
Copy link
Member

msporny commented Aug 10, 2022

Also a wallet rendering proposal here: https://github.com/decentralized-identity/wallet-rendering

@iherman
Copy link
Member

iherman commented Aug 10, 2022

The issue was discussed in a meeting on 2022-08-10

  • no resolutions were taken
View the transcript

4.5. Define v2 context (issue vc-data-model#42)

See github issue vc-data-model#42.

Kristina Yasuda: Looks like there is agreement to close this issue. Dave, any context?.

Dave Longley: We decided to defer this to 2.0, and I believe we should do this work. We should add name, description, etc. to the data model. There are further things about rendering hints, etc..
… I think there was agreement this would be addressed in v2.

Kevin Dean: +1.

Phil Archer: I think it's relevant too. In GS1 issued VCs we want to include some human-readable information.
… I worry about internationalization and accessibility. This should be considered.

Brent Zundel: there is also this: https://github.com/decentralized-identity/wallet-rendering.

Kristina Yasuda: Will keep the issue open.

@msporny
Copy link
Member

msporny commented Oct 9, 2022

Progress was made at RWoT. Progress snapshot available here: https://github.com/WebOfTrustInfo/rwot11-the-hague/blob/master/draft-documents/rendering-vcs-snapshot-9-27-22.md

@Sakurann
Copy link
Contributor

closing as a duplicate of #928

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

8 participants